slowly deprecate skip_event#291
Merged
truthbk merged 1 commit intoDataDog:masterfrom Mar 7, 2017
flyinprogrammer:help_deprecate_skip_event
Merged
slowly deprecate skip_event#291truthbk merged 1 commit intoDataDog:masterfrom flyinprogrammer:help_deprecate_skip_event
truthbk merged 1 commit intoDataDog:masterfrom
flyinprogrammer:help_deprecate_skip_event
Conversation
Member
|
Yeah, you're probably right! Thank you so much, as always @flyinprogrammer! Could you rebase to the latest |
Contributor
Author
|
should be all set now 😄 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should default this to true since ya'll have been trying to deprecate this feature since 5.3
https://github.com/DataDog/dd-agent/blob/master/checks/network_checks.py#L178-L180